deprecate method_missing in cheffish merged_config

chef / cheffish

Resources and tools for testing and interacting with Chef and Chef Server.

Apache License 2.0

38 stars 28 forks source link

deprecate method_missing in cheffish merged_config #129

Closed lamont-granquist closed 7 years ago

lamont-granquist commented 7 years ago

typical "method_missing is terrible" reasons...

lamont-granquist commented 7 years ago

since this is a very base library object i don't want to use the chef logger and do not want to introduce a dep on chef itself (as a circular dep that is just going to cause endless pain and suffering).

its very likely that any WARNs emitted by this will be internal to our own chef-org codebase anyway.

lamont-granquist commented 7 years ago

The only WARNs i got in chef-provisioning-fog for this were caused entirely by a very twisty rabbit hole caused entirely by #130 and will be gone once that is fixed. None of the code in that repo deliberately used this method_missing API. The fact that method_missing masked a bug is another good reason why it needs to go away.