chef / concrete

Concrete enhances your rebar based Erlang project by providing a common Makefile wrapper, a dialyzer make target that caches PLT analysis of your project's dependencies, and a mechanism to specify development only dependencies.
Apache License 2.0
56 stars 15 forks source link

print-newline-when-building-releases #14

Closed jkakar closed 10 years ago

jkakar commented 10 years ago

This changes this output:

jkakar@rex:~/src/github.com/heroku/keg$ make devrel
rm -rf _rel
==> edown (compile)
==> rebar_lock_deps_plugin (compile)
---- 8< snip 8< ---- 8< snip 8< ---- 8< snip 8< ---- 8< snip 8< ----
===> release successfully created!
Symlinking deps and apps into releasejkakar@rex:~/src/github.com/heroku/keg$

to this:

jkakar@rex:~/src/github.com/heroku/keg$ make devrel
rm -rf _rel
==> edown (compile)
==> rebar_lock_deps_plugin (compile)
---- 8< snip 8< ---- 8< snip 8< ---- 8< snip 8< ---- 8< snip 8< ----
===> release successfully created!
Symlinking deps and apps into release
jkakar@rex:~/src/github.com/heroku/keg$
seth commented 10 years ago

I noticed the missing newline earlier this week. Thanks for the fix!

seth commented 10 years ago

One small request for next time: format of git commit message should be single line summary ideally < 50 chars, empty line, then detail description (or [obvious fix] marker) as needed and hard wrapped to 72 cols.

I hope you'll consider setting up a CLA so that you can make more substantial contributions in the future :)

jkakar commented 10 years ago

Ah, thanks, will follow the commit format next time! And yeah, I'll get around to the CLA, have some ideas for non-"obvious fix" enhancements. :)

On Saturday, May 24, 2014, Seth Falcon notifications@github.com wrote:

One small request for next time: format of git commit message should be single line summary ideally < 50 chars, empty line, then detail description (or [obvious fix] marker) as needed and hard wrapped to 72 cols.

I hope you'll consider setting up a CLA so that you can make more substantial contributions in the future :)

— Reply to this email directly or view it on GitHubhttps://github.com/opscode/concrete/pull/14#issuecomment-44094878 .