Add Artifactory support

chef / cookbook-omnifetch

Fetch Chef Cookbooks from Various Sources to a Local Cache

Apache License 2.0

6 stars 9 forks source link

Closed thommay closed 7 years ago

thommay commented 7 years ago

Signed-off-by: Thom May thom@chef.io

coderanger commented 7 years ago

Maybe I'm misunderstanding how omnifetch works, but I don't see any authentication in here?

coderanger commented 7 years ago

Ahh, I think I see, ChefDK is passing in a concrete HTTP client object with the auth header already configured.

thommay commented 7 years ago

Yeah, the http object gets the auth and is DI'd in here.

And yes, there is definitely enough reuse that we can think about pushing some bits down in to the base class.