Flag Chef/Modernize/CronDFileOrTemplate offenses with string interpolation

yacn commented 2 years ago

Updates node matcher pattern for Chef/Modernize/CronDFileOrTempalte to capture everything in the file/template/cookbook_file resource declaration to catch offenses where the resource name is both a regular string and an interpolated string.

Description

The existing matcher does not flag offenses if the file/cookbook_file/template resource is named using string interpolation

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

since i don't use ruby outside of ChefDK, I need to put together a local dev env to run the tests in; doing so currently and will update the Checklist after I've done so and run the tests on my local machine. This has since been completed.

tas50 commented 2 years ago

@yacn This fails with this kind of code:

template config_file do
  source 'opt/docker-compose/app/athenz/docker-compose.yml'
  owner 'root'
  group 'root'
  mode '0644'
end

tas50 commented 2 years ago

I added a spec that will catch that scenario

yacn commented 2 years ago

@tas50 great catch! I originally modified the node matcher pattern to specifically look for an interpolated string but thought it might be more complicated and so used the larger capture (thinking it'd be simpler) thus which introduced the bug you added a test for.

tas50 commented 2 years ago

This found 26 new offenses on Supermarket which is more than the previous cop found. Nice improvement

chef / cookstyle