Chef/Modernize/CronDFileOrTemplate Improvements

[yacn]

Description

• updates the node pattern matcher macro to a stricter pattern to simplify its use
• checks the path if provided to the resource to cover cases where the path is provided to it and not the name property

Related Issue

https://github.com/chef/cookstyle/issues/943

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• [x] I have read the CONTRIBUTING document.
• [x] I have run the pre-merge tests locally and they pass.
• [x] I have updated the documentation accordingly.
• [x] I have added tests to cover my changes.
• [x] All new and existing tests passed.
• [x] All commits have been signed-off for the Developer Certificate of Origin.

[tas50]

This is a great improvement. Thanks

[tas50]

@yacn This PR is a bit too aggressive on finding issues. You probably want to add a doesn't detect spec for something like this:

template '/etc/mysql/cakephp-grants.sql' do
  path '/etc/mysql/cakephp-grants.sql'
  source 'grants.sql.erb'
  owner 'root'
  group 'root'
  mode '0600'
  variables(
    user: node['cakephp']['db']['user'],
    password: node['cakephp']['db']['password'],
    database: node['cakephp']['db']['database']
  )
  notifies :run, 'execute[mysql-install-cakephp-privileges]', :immediately
end

[tas50]

@yacn Let me know if you see any issue with https://github.com/chef/cookstyle/pull/945

[yacn]

This PR is a bit too aggressive on finding issues. You probably want to add a doesn't detect spec for something like this:

Great catch!