Fix #970: Add extra stub to pass ConfigValidator - Githubissues

chef / cookstyle

A linting tool that helps you to write better Chef Infra cookbooks and InSpec profiles by detecting and automatically correcting style, syntax, and logic mistakes in your code.

Apache License 2.0

107 stars 54 forks source link

Fix #970: Add extra stub to pass ConfigValidator #971

Closed dafyddcrosby closed 2 months ago

dafyddcrosby commented 4 months ago

We need to pass TargetChefVersion into the default config, otherwise the ConfigValidator#each_invalid_parameter method complains

Description

Related Issue

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[X] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
[ ] All new and existing tests passed.
[X] All commits have been signed-off for the Developer Certificate of Origin.

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

tpowell-progress commented 2 months ago

Lets use nil instead, which will make the monkeypatch use '99', which I think is the desired behavior.

@jaymzh calling this resolved, per @dafyddcrosby's latest changes.