search

chef / dep-selector-libgecode

Bundled Gecode Libraries for dep-selector
Apache License 2.0
11 stars 26 forks source link

fix for SmartOS (all SunOS), fixes #34 #41

Closed bahamas10 closed 4 years ago

bahamas10 commented 9 years ago

if you look at https://github.com/chef/dep-selector-libgecode/issues/34#issuecomment-67898575, you can see that a lot of lying about the underlying operating system is already taking place... this just adds SunOS to that list of lies.

With this I'm able to compile on SmartOS, which is the first step in getting omnibus-chef to work.

lamont-granquist commented 8 years ago

yeah but we're currently shipping on real SunOS including Solaris 10 and Solaris 11, is this going to break Solaris 10?

hjhart commented 7 years ago

Just ran into this problem myself. Any plans on merging this in?

hjhart commented 7 years ago

@lamont-granquist Is there an official maintainer of this gem?

lamont-granquist commented 5 years ago

This looks like a hack to lie that all of SunOS is Linux which I have to assume will make SmartOS work but will break our Solaris builds.

If I'm correct in that assumption, then I can't allow this to go in, no matter how much it helps SmartOS users.

If I'm incorrect, then I need to get an explanation (ideally in a comment in the code so its documented for posterity) of why this fixes SmartOS without breaking Solaris.

bahamas10 commented 5 years ago

I haven't touched this code in years (I have a compiled version of Chef I manually just ship around for my own setup). I agree though that this is a hack, and will probably break Solaris while working for SmartOS.

I won't really have the time to fully investigate this as much as I should to keep this PR opened/maintained, so please feel free to close this. Apologies to anyone in the SmartOS community that wants this. I am happy to test any changes that others in the community may have wrt SmartOS though.

tas50 commented 4 years ago

Closing this based on the comment from @bahamas10. If someone wants to pick this up in a way that fixes SmartOS while retaining support for Solaris that'd be great.