search

chef / effortless

Automated best practices for Chef Infra and Chef InSpec
https://chef.io
Apache License 2.0
33 stars 38 forks source link

update bootstrap to simplify package name capturing #254

Closed mbainter closed 3 years ago

mbainter commented 3 years ago

This updates the ls command to get the latest package file from the results directory to use ls -1 instead of parsing the ls output with cut.

Also includes a few documentation fixes to bring those docs up-to-date with what is in the example directory.

Signed-off-by: Mark Bainter mbainter@gmail.com

chef-expeditor[bot] commented 3 years ago

Hello mbainter! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

kagarmoe commented 3 years ago

Hi @mbainter! Thank you for your contribution. We're sorry for the delay in responding to your PR, we've been working on some big changes in our documentation. One of which is that we've renamed the docs component to docs-chef-io. Since the @chef/docs-team can't access your remote branch, could you move your changes from effortless-chef-io/content/effortless/effortless_config.md to docs-chef-io/content/effortless/effortless_config.md. Thanks!

TheLunaticScripter commented 3 years ago

I don't think this is the right way forward for the local dev examples. I think that a much better way to get local development is to start looking at the kitchen-habitat plugin. I'm going to close this out. Adding back in the bootstrap pieces is not necessary and is from an older way of doing things and the cut is a necessary element so that the hab pkg install command is using a direct path to install the hart on the test system. Yes there are places to improve the local development but I think the kitchen file needs to be updated to us the kitchen-habitat plugin instead of the shell provisioner.