chef / kitchen-vcenter

A test-kitchen driver for vCenter REST API
https://www.chef.io/implementations/vmware
Apache License 2.0
25 stars 26 forks source link

Enable setting guestinfo #153

Closed jasonwbarnett closed 3 years ago

jasonwbarnett commented 3 years ago

Description

This PR aims to enable setting guestinfo from test-kitchen.

Related Issue

Types of changes

Checklist:

jasonwbarnett commented 3 years ago

@tas50 this is by and large ready to go, but I want to test this against production before giving you the go ahead. I'll also be adding at least a few more unit tests.

jasonwbarnett commented 3 years ago

@tas50 I validated this is all working in production. This is ready for review 👁️

thheinen commented 3 years ago

My 2 ct:

Very glad to see the start of testability in this driver, as it grew and grew... and the fear of breaking something grew as well (for me at least). I will probably steal some of that code for my own projects :-)

Also, adding guestinfo crossed my mind a while ago as well. I think it's a good addition :+1: