PATHs containing spaces cause the bootstrap file to not be assembled completly

chef / knife-windows

Plugin for Chef's knife tool for working with Windows nodes

Apache License 2.0

152 stars 110 forks source link

PATHs containing spaces cause the bootstrap file to not be assembled completly #18

Closed jimktrains closed 12 years ago

jimktrains commented 12 years ago

In lib/chef/knife/core/windows_bootstrap_context.rb, the "SET PATH=%PATH%;etc" command fails when there is a space in %PATH%. It should somehow be quoted before hand or (what I ended up doing) using absolute paths to the executable.

btm commented 12 years ago

Thank you for supporting Knife! Our process has a couple prerequisites before we can merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on our ticket tracker for the release workflow. Pull requests are optional, but should always include the ticket number that they're related to for cross-referencing. Please take a moment to review the below wiki page for the appropriate steps:

http://wiki.opscode.com/display/chef/How+to+Contribute

jimktrains commented 12 years ago

I don't have a contribution, it's a bug report.

btm commented 12 years ago

Fixed here: http://tickets.opscode.com/browse/KNIFE_WINDOWS-13