search

chef / knife-windows

Plugin for Chef's knife tool for working with Windows nodes
Apache License 2.0
152 stars 110 forks source link

support --ssl-peer-fingerprint for self-signed winrm https hosts #298

Closed hh closed 8 years ago

hh commented 9 years ago

self signed host are just that... self signed. The certificate doesn't mean much, but verifying the fingerprint is just as good.

$ knife winrm --winrm-port 5986 --winrm-transport ssl --winrm-password 'FOOBARBAZ' --ssl-peer-fingerprint 758C4D9AC3E77F518529443D659E1260F5720400 -m 10.113.70.228 'winrm e winrm/config/listener'
10.113.70.228 Listener
10.113.70.228     Address = *
10.113.70.228     Transport = HTTPS
10.113.70.228     Port = 5986
10.113.70.228     Hostname
10.113.70.228     Enabled = true
10.113.70.228     URLPrefix = wsman
10.113.70.228     CertificateThumbprint = 758C4D9AC3E77F518529443D659E1260F5720400
10.113.70.228     ListeningOn = 10.113.70.228, 127.0.0.1, ::1, 2001:0:9d38:90d7:2022:2eca:f58e:b91b, fe80::5efe:10.113.70.228%14, fe80::14d9:e7a5:7df7:f42e%15, fe80::2022:2eca:f58e:b91b%13
10.113.70.228
mwrock commented 9 years ago

Commented at https://github.com/WinRb/WinRM/issues/151#issuecomment-145458056

hh commented 9 years ago

I think we are good as soon as WinRb/WinRM#151 is merged.

hh commented 9 years ago

313 should close this, feedback welcome

hh commented 8 years ago

344 is the new #313 updated to be a single commit against master

hh commented 8 years ago

It looks like #344 is ready to merge!

hh commented 8 years ago

@chef/client-windows @mwrock Do we look good here now?

mwrock commented 8 years ago

We have another minor version bump coming up and I want to get this included. Just need another maintainer +1 which I'll try to secure this week.

smurawski commented 8 years ago

Resolved by #350