chef / knife-windows

Plugin for Chef's knife tool for working with Windows nodes
Apache License 2.0
152 stars 110 forks source link

drop winrm-s dependency and allow both windows and linux to use negotiate auth #334

Closed mwrock closed 8 years ago

mwrock commented 8 years ago

This is a WIP PR dependent on the following downstream PRs: https://github.com/WinRb/rubyntlm/pull/26 https://github.com/WinRb/WinRM/pull/144

The above PRs allow the winrm gem to provide sspinegotiate authentication and eliminates the need for the winrm-s monkey patches. the winrm changes work with the current httpclent API as is injecting the appropriate headers so no patches needed for httpclient. Further, the winrm changes leverage the rubyntlm gem which implements negotiate authentication in pure ruby. This allows us to leverage negotiate on linux workstations and do away with the OS checks and warnings regarding plaintext on linux.

cc @sneal @zenchild

randomcamel commented 8 years ago

I'm not a domain expert, but LGTM. :+1:

adamedx commented 8 years ago

:+1:. We've removed @btm's helpful warning since negotiate now works universally, and I think that's appropriate.

mwrock commented 8 years ago

Just to note, this has been tested against: