search

chef / knife-windows

Plugin for Chef's knife tool for working with Windows nodes
Apache License 2.0
152 stars 110 forks source link

add support for winrm's new ssl fingerprint option #350

Closed mwrock closed 8 years ago

mwrock commented 8 years ago

This adds a minor fixup to @hh's PR #298 and tweaks the readme just a bit.

The ssl_fingerprint option was added in winrm 1.6 and this makes it accessible from knife.

smurawski commented 8 years ago

:+1:

danielsdeleo commented 8 years ago

:+1: Would be nice to explain how to generate the fingerprint.

danielsdeleo commented 8 years ago

Also, you might want to add this to the travis config:

branches:
  only:
  - master

So travis doesn't run twice on feature branches.

mwrock commented 8 years ago

yeah been meaning to make that travis mod. Will include that separately.

Funny we removed an example of grabbing the cert via openssl from the readme because if there is a man in the middle, you'd get his fingerprint.

mwrock commented 8 years ago

if its a self signed cert, which this feature is targetting, one should have easy access to the cert but you would either need a copy locally or hop on to the server to get it.

adamedx commented 8 years ago

:+1: