search

chef / knife-windows

Plugin for Chef's knife tool for working with Windows nodes
Apache License 2.0
152 stars 110 forks source link

Added code and corresponding RSpecs to read the json attributes from the --json-attributes-file option. #377

Closed Aliasgar16 closed 8 years ago

Aliasgar16 commented 8 years ago

Done. json attributes passed through --json-attributes-file option were not getting set into config object and so the attributes passed were then missing from the first_boot.json file.

Aliasgar16 commented 8 years ago

Pinned rack gem version in ci.gemfile as well.

mwrock commented 8 years ago

:+1:

btm commented 8 years ago

Can you use let instead of instance variables in the tests?

http://stackoverflow.com/questions/5359558/when-to-use-rspec-let

e.g.

let(:first_boot_attributes) { { 'a1' => 'b1', 'a2' => 'b2' } }
Aliasgar16 commented 8 years ago

Fixed the review comments.