search

chef / knife-windows

Plugin for Chef's knife tool for working with Windows nodes
Apache License 2.0
152 stars 110 forks source link

Fixing bootstrap via ssh regression #380

Closed NimishaS closed 8 years ago

NimishaS commented 8 years ago

w.r.t. https://github.com/chef/knife-windows/issues/372

NimishaS commented 8 years ago

Testing is in progress. @btm , @mwrock , shared the spreadsheet of testing.

Need to fix the specs too.

NimishaS commented 8 years ago

@btm , @mwrock I have updated the testing sheet with some of the scenarios that are failing. Most of them are not regressions. Please take a look.

mwrock commented 8 years ago

Just added comments to the spreadsheet. I think I think this was reported in a recent knife-windows issue due to casing. See https://github.com/chef/knife-windows/issues/382 informs 2 of the issues.

NimishaS commented 8 years ago

@mwrock , @btm , please review the changes. The failing cases reported in the sheet are not regressions. We can fix them as separate issues. Some specs have been removed in this PR as the corresponding ruby code has been removed while moving the logic to find machine architecture from ruby to .bat file

mwrock commented 8 years ago

LGTM :+1:

btm commented 8 years ago

👍