search

chef / knife-windows

Plugin for Chef's knife tool for working with Windows nodes
Apache License 2.0
152 stars 110 forks source link

Add validation for FQDN value #381

Closed dheerajd-msys closed 8 years ago

dheerajd-msys commented 8 years ago

Fix for issue https://github.com/chef/knife-windows/issues/378

mwrock commented 8 years ago

We shouldprobably just call validate_name_args! in the run methods of both winrm and ssh commands.

dheerajd-msys commented 8 years ago

Hi @mwrock sure, have updated my code to use validate_name_args! and added specs accordingly

mwrock commented 8 years ago

Nice. Now validate_name_args! can be removed from https://github.com/chef/knife-windows/blob/710bceb8c7c17cdde8f6f59591add920ce1d9d33/lib/chef/knife/bootstrap_windows_base.rb#L294

dheerajd-msys commented 8 years ago

@mwrock, Done, thanks for your feedback

mwrock commented 8 years ago

:+1: great. Tested locally with no host and got the expected actionable error.