search

chef / knife-windows

Plugin for Chef's knife tool for working with Windows nodes
Apache License 2.0
152 stars 110 forks source link

fix version comparison operations #421

Closed lamont-granquist closed 5 years ago

lamont-granquist commented 7 years ago

these don't work right, eg.:

Chef::VERSION.split('.')[0..1].join('.').to_f >= 12.5

12.130 is not >= 12.500

but chef 12.13 certainly is >= 12.5 #

lamont-granquist commented 7 years ago

there's some busted specs, gotta figure out what was actually intended because they clearly weren't working correctly before.

tas50 commented 5 years ago

Closing this out since we shouldn't do any of this now