search

chef / knife-windows

Plugin for Chef's knife tool for working with Windows nodes
Apache License 2.0
152 stars 110 forks source link

Removed deprecated host_key_verification, distro and template_file options #470

Closed dheerajd-msys closed 5 years ago

dheerajd-msys commented 5 years ago

Signed-off-by: dheerajd-msys dheeraj.dubey@msystechnologies.com

Descriptions

Resolved Issue

Fixes https://github.com/chef/knife-windows/issues/469

tas50 commented 5 years ago

Agree with @rhass here. Let's make sure we nuke every mention of this old option including our tests.

dheerajd-msys commented 5 years ago

Thanks @tas50 and @rhass I will do that.

dheerajd-msys commented 5 years ago

We may need to update travis and appveyor to get all these green. Travis and AppVeyor is failing for Environment: ruby_version=24, chef_version=~>13.0.

@rhass & @tas50 Could you please take a look?

tas50 commented 5 years ago

@dheerajd-msys looks like travis is failing on this spec that's still using the distro flag: https://github.com/chef/knife-windows/blob/master/spec/unit/knife/bootstrap_windows_winrm_spec.rb#L48

tas50 commented 5 years ago

As part of this PR you can remove Chef 13 testing since we'll require Chef 14 or later. We probably want to note that in the readme. You can also change the minimum required ruby version to 2.4 in the gemspec since that's the same as what Chef 14 required.

dheerajd-msys commented 5 years ago

@tas50 Problem here is that even if we remove chef v13 and use chef v14 it will still not make travis happy. Because --identity-file option is not removed yet from chef v14 as you can see here https://github.com/chef/chef/blob/v14.9.13/lib/chef/knife/bootstrap.rb#L81.

tas50 commented 5 years ago

We will probably need to keep identity_file for now then.