search

chef / ohai

Ohai profiles your system and emits JSON
https://docs.chef.io/ohai.html
Apache License 2.0
681 stars 450 forks source link

fix warning: already initialized constant MACROS_MARKER and warning: … #1759

Closed jkimalane closed 1 year ago

jkimalane commented 2 years ago

…already initialized constant DO_NOT_SPLIT

Description

Fixes warning issues:

/opt/chef/embedded/lib/ruby/gems/3.0.0/gems/ohai-17.9.0/lib/ohai/plugins/rpm.rb:25: warning: already initialized constant MACROS_MARKER
/opt/chef/embedded/lib/ruby/gems/3.0.0/gems/ohai-17.9.0/lib/ohai/plugins/rpm.rb:25: warning: previous definition of MACROS_MARKER was here
/opt/chef/embedded/lib/ruby/gems/3.0.0/gems/ohai-17.9.0/lib/ohai/plugins/rpm.rb:27: warning: already initialized constant DO_NOT_SPLIT
/opt/chef/embedded/lib/ruby/gems/3.0.0/gems/ohai-17.9.0/lib/ohai/plugins/rpm.rb:27: warning: previous definition of DO_NOT_SPLIT was here
sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

johnmccrae commented 2 years ago

Hi, can you please sign this PR.

jkimalane commented 2 years ago

Hi, can you please sign this PR.

Sorry, but I'm new to "signing PRs". So can I sign already submitted PR or do I have to create a new one?

vkarve-chef commented 2 years ago

@jkimalane you can push an amended commit with the sign-off, please ref this page

marcparadise commented 2 years ago

@jkimalane could you also rebase this on latest main?

jaymzh commented 2 years ago

ping @jkimalane

JMccProgress commented 1 year ago

@jkimalane - a DCO is still required for the integration of changes.

jaymzh commented 1 year ago

This was already fixed in main (in a slightly different way).