[Bacport #1741 to 16] networking/linux: Map src only default routes accordingly

[johnmccrae]

Signed-off-by: John McCrae john.mccrae@progress.com Signed-off-by: Neha Pansare neha.pansare@progress.com

Description

• This PR backports https://github.com/chef/ohai/pull/1741

• This PR also fixes windows unit test CI failures for 16-stable branch.

  
  Failures:
  
  1) Ohai::System plugin packages when on windows on 32 bit ruby behaves like windows_package_plugin gets package info
   Failure/Error:
         repo.open(key_path, reg_type) do |reg|
           reg.each_key do |key, _wtime|
             pkg = reg.open(key)
             name = pkg["DisplayName"] rescue nil
             next if name.nil?
  
             package = packages[name] = Mash.new
             WINDOWS_ATTRIBUTE_ALIASES.each do |registry_attr, package_attr|
  C:/hostedtoolcache/windows/Ruby/2.7.7/x64/bin/ruby.exe -I'D:/a/ohai/ohai/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.12.0/lib';'D:/a/ohai/ohai/vendor/bundle/ruby/2.7.0/gems/rspec-support-3.12.0/lib' 'D:/a/ohai/ohai/vendor/bundle/ruby/2.7.0/gems/rspec-core-3.12.0/exe/rspec' --pattern 'spec/**/*_spec.rb' failed
               value = pkg[registry_attr] rescue nil
               package[package_attr] = value unless value.nil?
  
   Win32::Registry::Error:
     The system cannot find the file specified.
   Shared Example Group: "windows_package_plugin" called from ./spec/unit/plugins/packages_spec.rb:226
   # ./lib/ohai/plugins/packages.rb:118:in `collect_programs_from_registry_key'
   # ./lib/ohai/plugins/packages.rb:139:in `block (2 levels) in <main>'
   # ./lib/ohai/dsl/plugin/versionvii.rb:137:in `instance_eval'
   # ./lib/ohai/dsl/plugin/versionvii.rb:137:in `run_plugin'
   # ./lib/ohai/dsl/plugin.rb:115:in `run'
   # ./spec/unit/plugins/packages_spec.rb:201:in `block (4 levels) in <top (required)>'
  
  2) Ohai::System plugin packages when on windows on 64 bit ruby behaves like windows_package_plugin gets package info
   Failure/Error:
         repo.open(key_path, reg_type) do |reg|
           reg.each_key do |key, _wtime|
             pkg = reg.open(key)
             name = pkg["DisplayName"] rescue nil
             next if name.nil?
  
             package = packages[name] = Mash.new
             WINDOWS_ATTRIBUTE_ALIASES.each do |registry_attr, package_attr|
               value = pkg[registry_attr] rescue nil
               package[package_attr] = value unless value.nil?
  
   Win32::Registry::Error:
     The system cannot find the file specified.
   Shared Example Group: "windows_package_plugin" called from ./spec/unit/plugins/packages_spec.rb:236
   # ./lib/ohai/plugins/packages.rb:118:in `collect_programs_from_registry_key'
   # ./lib/ohai/plugins/packages.rb:139:in `block (2 levels) in <main>'
   # ./lib/ohai/dsl/plugin/versionvii.rb:137:in `instance_eval'
   # ./lib/ohai/dsl/plugin/versionvii.rb:137:in `run_plugin'
   # ./lib/ohai/dsl/plugin.rb:115:in `run'
   # ./spec/unit/plugins/packages_spec.rb:201:in `block (4 levels) in <top (required)>'
  
  3) Ohai::System plugin packages when on windows on unknown ruby behaves like windows_package_plugin gets package info
   Failure/Error:
         repo.open(key_path, reg_type) do |reg|
           reg.each_key do |key, _wtime|
             pkg = reg.open(key)
             name = pkg["DisplayName"] rescue nil
             next if name.nil?
  
             package = packages[name] = Mash.new
             WINDOWS_ATTRIBUTE_ALIASES.each do |registry_attr, package_attr|
               value = pkg[registry_attr] rescue nil
               package[package_attr] = value unless value.nil?
  
   Win32::Registry::Error:
     The system cannot find the file specified.
   Shared Example Group: "windows_package_plugin" called from ./spec/unit/plugins/packages_spec.rb:246
   # ./lib/ohai/plugins/packages.rb:118:in `collect_programs_from_registry_key'
   # ./lib/ohai/plugins/packages.rb:139:in `block (2 levels) in <main>'
   # ./lib/ohai/dsl/plugin/versionvii.rb:137:in `instance_eval'
   # ./lib/ohai/dsl/plugin/versionvii.rb:137:in `run_plugin'
   # ./lib/ohai/dsl/plugin.rb:115:in `run'
   # ./spec/unit/plugins/packages_spec.rb:201:in `block (4 levels) in <top (required)>'

Finished in 1 minute 14.42 seconds (files took 2.95 seconds to load) 1770 examples, 3 failures, 1 pending

Failed examples:

rspec './spec/unit/plugins/packages_spec.rb[1:4:1:1:1]' # Ohai::System plugin packages when on windows on 32 bit ruby behaves like windows_package_plugin gets package info rspec './spec/unit/plugins/packages_spec.rb[1:4:2:1:1]' # Ohai::System plugin packages when on windows on 64 bit ruby behaves like windows_package_plugin gets package info rspec './spec/unit/plugins/packages_spec.rb[1:4:3:1:1]' # Ohai::System plugin packages when on windows on unknown ruby behaves like windows_package_plugin gets package info

The reason it wasn't happening on main is that exact line was getting rescued due to changes made here https://github.com/chef/ohai/pull/1699/files#diff-502d0db7f8ed18fe06ed8d24cd73481e897a269069631efcdf90058c8294e0b9R139. I rescued it here too, doesn't seem any harm in doing so.

## Related Issue
<!--- If you are suggesting a new feature or change, please create an issue first -->
<!--- Please link to the issue, discourse, or stackoverflow here: -->

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Chore (non-breaking change that does not add functionality or fix an issue)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] I have read the **CONTRIBUTING** document.
- [ ] I have run the pre-merge tests locally and they pass.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [ ] All commits have been signed-off for [the Developer Certificate of Origin](https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco).

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
43.9% Duplication

[jaymzh]

Did you git cherry-pick this (plus add the rescue)? Or did you manually backport this change? If it's manual, I'd want to go through and have a 2nd person compare this very carefully. If you git cherry-pickd and it was clean, then I'd say merge away.

[neha-p6]

Did you git cherry-pick this (plus add the rescue)? Or did you manually backport this change? If it's manual, I'd want to go through and have a 2nd person compare this very carefully. If you git cherry-pickd and it was clean, then I'd say merge away.

It was a manual change, since @johnmccrae found difference code base between main and 16-stable. We will take a relook before merging to avoid any human error.