Calling yajl parser only once - Githubissues

chef / ohai

Ohai profiles your system and emits JSON

https://docs.chef.io/ohai.html

Apache License 2.0

681 stars 452 forks source link

Calling yajl parser only once #1786

Closed rnt closed 1 year ago

rnt commented 1 year ago

In some plugins, YAJL parser is called twice. That's really inefficient.

Description

We definitely shouldn't fire off the YAJL parser twice if we don't need to.

Originally posted by @jaymzh in https://github.com/chef/ohai/pull/1780#pullrequestreview-1288003393

Related Issue

Add cloud provider oci #1780

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication