[block_device] Record firmware revision of nvme block devices

saravan2 commented 1 year ago

Enhancing the plugin to record the firmware of nvme block devices

Description

The sysfs end point for firmware in nvme block device differs from HDD. Added firmware_rev to the plugin check list to collect this information on servers with nvme block devices.

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

dafyddcrosby commented 1 year ago

Confirmed https://github.com/torvalds/linux/blob/master/drivers/nvme/host/core.c#L3554 and my laptop (Fedora 37, 6.1.11 kernel) for firmware_rev

jaymzh commented 1 year ago

Huh I don't see to be part of chef-infra-owners anymore. I'll need to get that fixed

GeorgeWestwater commented 1 year ago

Merge approved @jaymzh; please merge until we can fix the branch protection

jaymzh commented 1 year ago

Looks like the GHE migration yanked me out of the chef-infra-owners group, so the UI doesn't know I am allowed to approve. But I AM allowed to force the merge. So after talking to @GeorgeWestwater I'm forcing the merge, and they'll work on fixing groups.

chef / ohai