chef / ohai

Ohai profiles your system and emits JSON
https://docs.chef.io/ohai.html
Apache License 2.0
681 stars 452 forks source link

Adds status property to dpkg parsed packages #1799

Closed fretb closed 1 year ago

fretb commented 1 year ago

dpkg-query displays information about all packages on the system, meaning that removed (non-purged) packages that leave config-files are also in this list.

This makes it hard to identify actually installed packages. By adding the db:Status-Status field to our package info hash, we have a lot more flexibility.

Slack discussion about this: https://chefcommunity.slack.com/archives/C55FCUGBS/p1685438915205339.

Types of changes

Checklist:

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
66.7% 66.7% Duplication

Tensibai commented 1 year ago

I kinda disagree with the non-breaking change, it does change what's reported (due to dpkg query change) so it should have a kinf of warning aroung the distro/dpkg version bringing the change and a proper Changelog entry IMHO.

Main question is: I wonder what happen for old 18.04 ubuntu without this dpkg-query update or if it is not relevant as 18.04 always had this behavior anyway.

Misread the changes, it is totally backward compatible, sounds good to me.