search

chef / omnibus-ctl

Provides service control for omnibus packages
Apache License 2.0
23 stars 24 forks source link

blacklist removed services from *-ctl commands #10

Closed sdelano closed 10 years ago

sdelano commented 10 years ago

When running omnibus-ctl [status|start|restart|etc] for services that have been removed and are configured as removed (requires config to be written by the *-omnibus projects), we should not attempt to start the services or run any service commands against them unless specifically attempting to do so. Services that are removed can still be accessed by running:

*-ctl SV_COMMAND REMOVED_SERVICE

The previous behavior manifested itself as a race condition in Enterprise Chef where a service that was previously installed as part of an older version came up after a *-ctl start and stole the port from the service that was supposed to be running. This fixes that issue.

/cc @opscode/server-team @stevendanna @jamesc @irvingpop @ryancragun

jmink commented 10 years ago

:+1: The documentation needs to be updated to go with this.

irvingpop commented 10 years ago

Could we do something like this for opscode-chef-mover as well?

sdelano commented 10 years ago

@irvingpop yeah, that's a possibility. I know some people don't like that showing up when it's not running, and it causes *-ctl to return a non-zero status code. That's a bit different, because it's not a "removed" service. It could be a similar concept however. Like a "hidden" service.

irvingpop commented 10 years ago

awesome! :+1: