search

chef / omnibus-ctl

Provides service control for omnibus packages
Apache License 2.0
23 stars 24 forks source link

Use chef-client -z instead of chef-solo and reference by the full path. #23

Closed tylercloke closed 9 years ago

tylercloke commented 9 years ago

Uses chef-client -z instead of chef-solo which works around chef-solo --no-fork bug. Also chef-solo is going away in favor of chef-client -z soon, so this is work we will have to do anyway.

Also, prevent accidentally slurping in whatever is in the path by explicitly calling the full /opt/opscode/embedded/bin command since its just a system call. However, we should only do this if chef-server-ctl is the only project that uses the show-config and reconfigure commands. If that is not true, then just change to be chef-client -z.

sdelano commented 9 years ago

LGTM

seth commented 9 years ago

Wonder if we should consider some lint tooling to catch explicit paths like /opt/opscode it's easy to miss if that's all you see, but would make this change unusable for some projects :)

lamont-granquist commented 9 years ago

awesome :+1:

tylercloke commented 9 years ago

@seth Certainly worth considering! Also, we have a lot of implicit contracts around files, paths, etc. Would be nice to formalize some of those since things will actually break (random though).