Allow custom branding files to be placed somewhere outside of /opt

chef / supermarket

Chef's community platform

https://supermarket.chef.io/

Apache License 2.0

214 stars 114 forks source link

Allow custom branding files to be placed somewhere outside of /opt #1119

Open smith opened 8 years ago

smith commented 8 years ago

In #1111, the ability to use custom branding CSS was added. In order for you to do this on an installation, files must be placed in /opt/supermarket/embedded/service/supermarket/app/assets/stylesheets branding.

Because of the nature of /opt (see http://www.pathname.com/fhs/pub/fhs-2.3.html#OPTADDONAPPLICATIONSOFTWAREPACKAGES), configuration files should not be stored there, and /opt/supermarket should be able to be completely removed and reinstalled without losing and configuration data.

The CSS files should be stored somewhere in /etc/supermarket or somewhere in /var/opt/supermarket and symlinked into the proper places on reconfigure.

SolverDude commented 8 years ago

:+1: We're evaluating our own private supermarket, and having it look IDENTICAL to the public one is, at best, misleading. I'd definitely want to install our customization once and not need to remember to reinstall it upon an upgrade.

I'd actually like to add our company's logo to the header in our private supermarket, but that's in the 'maybe a great idea' category, and i'll submit an issue for that when i've thought through what would be best, or not if i find out there's a way that i just don't know yet. :-)

robbkidd commented 8 years ago

Thanks for the feedback, @SolverDude. Knowing who is interested in branding and why it is helpful for prioritizing issues.

robbkidd commented 7 years ago

Putting this issue in the queue for consideration this week.

Make it easier to re-run assets:precompile in production when branding has been added/changed
(as this issue points out) Bring in branding from somewhere that is not overwritten by a Supermarket omnibus package install/upgrade

robbkidd commented 6 years ago

Have not changed any of the branding mechanisms, but I have opened a PR to document how to customize branding with the current code base. It's not the prettiest solution, but works reliably for those who are already managing their private Supermarkets with a wrapper cookbook.