search

cheind / tf-matplotlib

Seamlessly integrate matplotlib figures as tensorflow summaries.
MIT License
119 stars 17 forks source link

Explicitly pass values kwarg to tf.name_scope #3

Open bananabowl opened 5 years ago

bananabowl commented 5 years ago

Explicitly pass values kwarg to tf.name_scope as it is currently being treated as the default_name kwarg instead. This causes an exception to be thrown in eager mode.

bananabowl commented 5 years ago

Friendly ping!

cheind commented 5 years ago

sorry, I'm awaiting the build check (which failed last time for non obvious reasons). Once passed, I will merge.

bananabowl commented 5 years ago

Looks like the build check failed for a different reason:

https://ci.appveyor.com/project/cheind/tf-matplotlib/builds/24248719/job/et0kls2215q8b0jt

Installing collected packages: tfmpl *** Error compiling 'C:\Users\appveyor\AppData\Local\Temp\1\pip-install-ydipx5en\tfmpl\tfmpl\samples\mnist.py'... File "C:\Users\appveyor\AppData\Local\Temp\1\pip-install-ydipx5en\tfmpl\tfmpl\samples\mnist.py", line 79 print(f'Iteration {i}') ^ SyntaxError: invalid syntax

*** Error compiling 'C:\Users\appveyor\AppData\Local\Temp\1\pip-install-ydipx5en\tfmpl\tfmpl\samples\sgd.py'... File "C:\Users\appveyor\AppData\Local\Temp\1\pip-install-ydipx5en\tfmpl\tfmpl\samples\sgd.py", line 76 xys = [tf.getvariable(f'xy{o[1]}', 2, tf.float32, initializer=start) for o in optimizers] ^ SyntaxError: invalid syntax