chellygel / AnimeKetchup

Some anime you want to watch? How fast can you catch up?
1 stars 0 forks source link

Introduce Episodes into Easy Flow #20

Open leepatrickworrall opened 1 year ago

leepatrickworrall commented 1 year ago

Per what you said, don't shout at me.

image

leepatrickworrall commented 8 months ago

@chellygel Remember what this intended? It's been so long, I'm lost.

chellygel commented 8 months ago

wow, someone who knows how to project manage should really be better about writing tickets and comments. 🤦‍♀️ 🤣

Uhm. looking at this test in context right now:

def test_calculate_wsb_valid_response():
    end_date = dt.datetime(2024, 11, 11)
    start_date = dt.datetime(2024, 11, 1)

    response = wsb.calculate_watch_schedule(50, end_date, start_date)

    assert response["base_eps_per_day"] == 5
    assert response["days"] == 10
    assert response["actual_watch_days"] == 10
    assert response["is_possible"] is True
    assert response["realistic_end_date"] is None
    assert response["extra_episodes"] is None

The amount of days is 10, the amount of episodes is 51... My comment was suggesting that the extra_episodes would return "1 episode" as in, 5 episodes per day for 10 days with 1 episode left over.... But that would be incorrect because that only matters when people put a limit of how many episodes per day they are willing to watch... not when we do the best calculation for them without limits.

My comment was suggesting that as the code is written the most basic flow of using it (start date, end date, number of episodes (the "easy flow")) should follow the same logic path that the limit_eps_per_day flow does where it says "you can either watch 5 eps per day with 1 extra OR watch 6 eps per day and finish early"

Does that help @leepatrickworrall

leepatrickworrall commented 8 months ago

Hey, you told me to add a ticket. I added a ticket. Just with your own words 😂 However, that more assists me in understanding what you were first mentioning.