search

chellymehdi / vopenlayers

Automatically exported from code.google.com/p/vopenlayers
0 stars 0 forks source link

Layer object hierarchy should be refactored #117

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I think it would simplify the object model, more closely align the object model 
with OpenLayers, and greatly reduce redundant code if all Layers descended from 
an AbstractLayer class (on both server and client sides) that provided 
implementation code for common methods and fields.

This is a large undertaking now ... but it is only going to get worse over 
time.  I am willing to help out with the grunt code work, but we do need some 
initial re-design work.

Original issue reported on code.google.com by jr...@redzonesoftware.com on 30 Nov 2012 at 3:59

GoogleCodeExporter commented 9 years ago 
Maybe a good starting point will be vector and web feature service layer

Original comment by eiko.tho...@gmail.com on 11 Dec 2012 at 10:05

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Eiko,

I removed the patch I had attached for this ... it worked fine for the layers 
that extend AbstractComponent, but was problematic for the VectorLayer, which 
extends AbstractComponentContainer.
The problem I'm having here is coming up with a solution that will not involve 
duplicating code because of the different inheritance hierarchies.  Perhaps 
shift all of the other layers over to the AbstractComponentContainer hierarchy? 
 At this point they really aren't containers, but I don't think treating them 
as such would hurt anything.
Do you have some ideas on this?

Thanks,
John Ryan

Original comment by jr...@redzonesoftware.com on 15 Jan 2013 at 11:00