search

chellymehdi / vopenlayers

Automatically exported from code.google.com/p/vopenlayers
0 stars 0 forks source link

Changes to use own URL pattern in OpenStreetMapLayer #88

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I checked out the vaading OpenLayers add-on and found I missed the feature to 
use my own tiles server instead the original servers from OpenStreetMap.The 
attached file contains my changes to extend your add-on. I hope you also find 
it useful an find a way to integrate this in the regular code.

To install the patch change into the org folder in source directory and call

'patch [--dry-run] -p1 -i org.patchfile'

Kind regards,
Eiko

Original issue reported on code.google.com by eiko.tho...@gmail.com on 15 Sep 2012 at 2:44

Attachments:

GoogleCodeExporter commented 8 years ago 
Not a contributor (wish I was -- I have a fix for the bounds checking above 
too) ... and this is a needed change too since I also have a different tile 
server than OSM ...

Original comment by sjmcdow...@gmail.com on 15 Sep 2012 at 5:43

GoogleCodeExporter commented 8 years ago 
Hi,

Great work. I committed the patch partly to SVN in r167.

I assume the parts to OpenLayersMap are obsolete?

Some comments for patch:
 * A test case for this feature would be a must have so we don't break it in the future.  We'll close this issue an make new release once there is a test I can tryout.
 * create patches with "svn diff > mypatch.diff" style.
 * use four spaces instead of tabs for indentation. If using eclipse, these settings would be pop: http://dev.vaadin.com/svn/versions/6.8/eclipse/
 * API docs for server side API would be nice addition, client side can survive without if the code is readable enough

I'll add your account as contributor so you can commit in directly, but please 
track stuff with issues reports like this so I can review new changes easily. 

cheers,
matti

Original comment by ma...@vaadin.com on 5 Oct 2012 at 11:44

GoogleCodeExporter commented 8 years ago 
Hi Matti,
thank you for the response, I will respect your comments next time.
Kind regards,
Eiko

Original comment by eiko.tho...@gmail.com on 9 Oct 2012 at 5:24

GoogleCodeExporter commented 8 years ago 
Finished

Original comment by eiko.tho...@gmail.com on 25 Oct 2012 at 9:43