screen is broken for multipe SpinnerManager

chelnak / ysmrr

YSMRR is a package that provides simple multi-line compatible spinners for Go applications.

MIT License

71 stars 6 forks source link

screen is broken for multipe SpinnerManager #66

Open arturrez opened 2 months ago

arturrez commented 2 months ago

when using multiple SpinnerManager on a screen which works fine except a situation when one of the SpinnerManager spinners is pushed out of the screen with other outoput. Once spinner is out of the view screen keeps going back and forth which breaks UX. Is there any way to stop rendering spinners when they out of the view?

chelnak commented 2 months ago

Hey @arturrez !

I think I understand your issue.

You have two spinner managers doing lots of work
If the second spinner manager goes off the current screen (creating more spinners) it breaks the buffer and causes the refresh to break

At the moment I don't think there is a way to stop something rendering if it is out of bounds.. it could be possible though (I think).

Can you post a small repro? It would help me debug the issue.

arturrez commented 2 months ago

thank you. You are correct - this is the issue. I don't think I can provide repro case unless you want to use avalanche-cli:) ./bin/avalanche node create p25 --use-static-ip=false --latest-avalanchego-version=true --aws --region us-east-1 --num-validators=25 --fuji --node-type=default will show the issue. You might need to setup some dependencies like AWS account

chelnak commented 2 months ago

Ok got it. I'll work something out.

Thanks!