search

chembl / GLaDOS

Web Interface for ChEMBL @ EMBL-EBI
https://www.ebi.ac.uk/chembl/
Other
46 stars 6 forks source link

Withdrawal information tag should be added to summary in compound report card #689

Closed FionaEBI closed 6 years ago

FionaEBI commented 6 years ago

Please can a small coloured tag be added to the top mini-card of the compound report card to show that an approved drug has been withdrawn. The withdrawal information is further down the compound report card, but should be obvious from the summary information at the top of the compound report card.

I suggest that a tag could be added on the 'Max Phase' row, after the 'Approval' tag.

Withdrawal information is important for investigating known toxicity / side effects.

See snapshot image: screen shot 2018-03-14 at 16 05 15

mnowotka commented 6 years ago

Wow, thanks for reporting this Fiona, this really is important. When this is fixed we need a GhostInspector tests that will check if withdrawn flag is indicated in the "Name and Classification" component. Just to provide a link to example, here it is: https://chembl-glados.herokuapp.com/compound_report_card/CHEMBL121/

laurajunco commented 6 years ago

This is deployed now: https://chembl-glados.herokuapp.com/compound_report_card/CHEMBL408/ And I also already added the ghost inspector test case

nclopezo commented 6 years ago

Hi @FionaEBI, Could you please confirm that this is OK for you?

FionaEBI commented 6 years ago

Hi David, This looks great! Thank you! I like the mouse 'hover over' text for Withdrawn drugs tag. Fiona

On 19 Mar 2018, at 16:59, David Mendez notifications@github.com wrote:

Hi @FionaEBI https://github.com/fionaebi, Could you please confirm that this is OK for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chembl/GLaDOS/issues/689#issuecomment-374286965, or mute the thread https://github.com/notifications/unsubscribe-auth/AfXzWh4TE5IyopMqfTzYTpSbesOWNcynks5tf-PvgaJpZM4SquoL.

Dr Fiona M I Hunter CChem MRSC Chemogenomics Group European Bioinformatics Institute (EMBL-EBI) Wellcome Genome Campus Hinxton Cambridge CB10 1SD United Kingdom

01223 494317 fiona.hunter@ebi.ac.uk mailto:fiona.hunter@ebi.ac.uk

nclopezo commented 6 years ago

For the record, this has been added to the ghost inspector tests for the compound report card: https://app.ghostinspector.com/tests/58aac2ea3d2a4d2b8cdb8e3f