search

chembl / chembl_webresource_client

Official Python client for accessing ChEMBL API
https://www.ebi.ac.uk/chembl/api/data/docs
Other
368 stars 95 forks source link

Not compatible with Python37 - async is now a keyword #40

Closed cthoyt closed 4 years ago

cthoyt commented 6 years ago

There are several places where the name async has been used as a variable name. Since this is now a keyword in Python37, the interpreter will send a SyntaxError.

@jmarinllao will send a PR soon :)

cthoyt commented 5 years ago

Any updates? There are now two distinct pull requests related to this issue

dprada commented 5 years ago

To @cthoyt, @jmarinllao and @dmyersturnbull: I have a forked repo where 'async' was replaced by 'asynchr' since async is a reserved keyword in Python 3.7. I also had to fork gevent-openssl to build it in conda for Python 3.7.

The package can be checked and tested in the uibcdf channel at conda:

conda install -c uibcdf gevent-openssl
conda install -c uibcdf chembl_webresource_client

I don't think doing a PR solves the Python 3.7 compatibility. Maybe ChEMBL should have its own forked gevent-openssl repo built for Python 3.7.

eloyfelix commented 4 years ago

We just pushed some changes to the master branch that should fix most of the issues. Py2 compatibility is dropped as it's support is expiring by the end of the year. (https://pythonclock.org/, https://python3statement.org/).

We also dropped TargetResource and CompoundResource components that worked using already deprecated endpoints.

You can try it by installing from the master branch. We'll be providing new packages soon.

pip install https://github.com/chembl/chembl_webresource_client/archive/master.zip
eloyfelix commented 4 years ago

New version is already available in pypi: https://pypi.org/project/chembl-webresource-client/

so it can be installed from it:

pip install chembl-webresource-client
cthoyt commented 4 years ago

Wonderful! Thank you!!!