search

chembl / chembl_webresource_client

Official Python client for accessing ChEMBL API
https://www.ebi.ac.uk/chembl/api/data/docs
Other
368 stars 95 forks source link

Fixing Python 3.7 incompatibility with async keywords #43

Closed jmarinllao closed 4 years ago

jmarinllao commented 6 years ago

closes #40 Even though was fixed the async problem, there is still a problem with gevent.

nhstanley commented 5 years ago

FYI, this works for me with python3.7. Further, the failing Travis test seems to be because the python3.6 test isn't actually testing python3.6, but bizarrely python2.7.

eloyfelix commented 4 years ago

thanks for this but because we are dropping the old webservices resources (CompoundResource, TargetResource...) and Py2 compatibility this PR won't be necessary.

naefl commented 4 years ago

Hey @eloyfelix.

I still get the error

File "/opt/conda/lib/python3.7/site-packages/chembl_webresource_client/web_resource.py", line 184 def _get_one(self, url, async, frmt, method='get', data=None):

python 3.7.4

chembl-webresource-client 0.9.31

eloyfelix commented 4 years ago

Hi naefl, we didn't update yet the packages in pip and conda. If you want to try the changes in the repo you can install the package from the master branch

pip install https://github.com/chembl/chembl_webresource_client/archive/master.zip
eloyfelix commented 4 years ago

New version is already available in pypi: https://pypi.org/project/chembl-webresource-client/

so it can be installed from it:

pip install chembl-webresource-client