search

chembl / curation-interface

This is repository to track all bugs and issues related to development of the curation interface
0 stars 0 forks source link

Where has the option to Split gone? #111

Open ljbellis opened 9 years ago

ljbellis commented 9 years ago

I have drawn a compound which I know exists in ChEMBL.

I have clicked on 'Save All To ChEMBL'

and I get this window....

There is no option to split or redraw....

Only if you click on Update do you then get the window that says this compound already exists.

This is a confusing step. question

mnowotka commented 8 years ago

This is correct. If compound already exists in the database you can't make 'Split' by the definition of 'Split'. Split (as currently defined in the application logic) is: create new compound and move some records from some selected old compound to the new one. Since the compound already exists, there is no possibility to create new one so 'Split' option is not offered.

In general, after clicking 'save to ChEMBL' button, you will get two different sets of options:

  1. Update | New Record | Move | Merge | Edit (Curate) | Cancel - if compound exists or:
  2. Insert new compound | Redraw | Split | Cancel - if compound doesn't exist
mnowotka commented 8 years ago

Because I believe that this is a correct behavior, I'm assigning this to Louisa to clarify or close this issue.

ljbellis commented 8 years ago

No, I think there should be an option to split for a compound which already exists.

here is the scenario:

I am looking at Compound X. It has 3 records. One of those records should be linked to Compound A. I don't know if Compound A exists, I just draw it into the window and click on Save.

Interface tells me it exists but does not give me the opportunity to split records from another compound.

mnowotka commented 8 years ago

This is possible. This operation is just called MERGE. This is again 'just' about naming. I will paste a diagram, which describes how all operations are defined.

ljbellis commented 8 years ago

Merge is where you merge ALL the records from one compound to another

ljbellis commented 8 years ago

We had a long conversation about the differences with these.

mnowotka commented 8 years ago

This is MOVE :)

mnowotka commented 8 years ago

Yes, and all I say is that the functionality is there already. And no, I haven't change any names yet.

ljbellis commented 8 years ago

Ok, but if this is going to work for me, then the terminology needs to be relevant to me and my work.

Also, if Merge and Split do the same thing, but one is for new compounds and one is for existing, then this isn't really useful. They would need to have the same name for the same function.

In my opinion.

mnowotka commented 8 years ago

Yes, I completely agree to this.

mnowotka commented 8 years ago

This is a document that describes current logic of the core operations offered by the curation interface: usecases