Change 'Curate' to 'Open' and remove 'Cancel' for existing compounds

chembl / curation-interface

This is repository to track all bugs and issues related to development of the curation interface

0 stars 0 forks source link

Change 'Curate' to 'Open' and remove 'Cancel' for existing compounds #112

Open ljbellis opened 9 years ago

ljbellis commented 9 years ago

When you use the magnifying glass to find an existing compound, you get this window (below)

Both OK and Cancel have the same function,in that they close the pop up window and go back to the Load_compounds interface. I would choose one and discard the other.

If you click on the Curate button, it takes you to the Edit Compound interface. However, I think this should be changed to 'Edit/Open Compound' or similar. Someone might not particularly want to curate a compound and might think that by pressing this, it will do something they don't want to do.

Once you're in the Edit Compound page, it is obvious that you can curate things.

cancel

mnowotka commented 9 years ago

This is fixed. Please verify.

ljbellis commented 9 years ago

No, the window says EDIT, not Open.

Please can you change EDIT to CURATE to match my request in

https://github.com/chembl/curation-interface/issues/145

Also can you remove the OK button as the X does the job perfectly well and the only reason people would be clicking on the search button is because they actually want to do something with the compound.

mnowotka commented 9 years ago

On top of this issue you say: "However, I think this should be changed to 'Edit/Open Compound' or similar" And this is why I've deliberately changed all the buttons with 'Curate' to 'Edit'. Sure, I can change it back, but I believe we just started focusing on minor cosmetic details.

ljbellis commented 9 years ago

In this case, we need consistency between these two windows.

My main issue was that EDIT was white and wasn't that obvious.

I am happy to keep them as EDIT but make the button blue and make it the only button there.

mnowotka commented 9 years ago

I closed issue https://github.com/chembl/curation-interface/issues/145 to keep the discussion on one place and I'm removing 'critical' label as this is minor cosmetic issue:

you can close window in two places, which is nothing wrong and most dialog windows behave similar.
is 'Edit' or 'Curate' a better label for button.

mnowotka commented 9 years ago

Yes, they are consistent across whole web app now.

ljbellis commented 9 years ago

Ok should be removed. One button to remain.

EDIT or OPEN or CURATE