search

chembl / curation-interface

This is repository to track all bugs and issues related to development of the curation interface
0 stars 0 forks source link

You can type over the Source in the Add New Compound Record #125

Closed ljbellis closed 9 years ago

ljbellis commented 9 years ago

Find a known compound in ChEMBL Go to its edit compound page Add a new record by using the Add New Compound Record box. Go to Find Document and choose Default

At this point it is feasible that maybe you would like to add your own source that isn't in the list. For whatever reason. You can directly type over the contents of the list. It does tell you that whatever you have typed isn't in the list but allows you to keep it there.

You can then click on OK and it is saved.

When you go back to the compound page, the new record is there but it has given it a source of AstraZeneca due to that being the first source in the list. This needs to be fixed.

I would say that you should be allowed to overwrite this source list and that the source is then recognised and saved internally. <--- This is more for external people. For us, I would say remove the ability to overwrite altogether.

unpublished

az

mnowotka commented 9 years ago

I'm linking this with https://github.com/chembl/curation-interface/issues/127 as they can be solved in one go.

mnowotka commented 9 years ago

This is fixed. Please verify.

ljbellis commented 9 years ago

I can't overwrite. It won't save.

However, the error message is wrong. It says the source named null, but it's not null, you've typed it. Maybe a better error message is 'INCORRECT SOURCE ENTERED" or something?

source

mnowotka commented 9 years ago

Sure, no problem.

mnowotka commented 9 years ago

The description has been changed.

ljbellis commented 9 years ago

thanks