search

chembrows / ChemBrows

ChemBrows keeps you up-to-date with scientific literature
http://www.chembrows.com
GNU Lesser General Public License v3.0
5 stars 4 forks source link

Support new, preferred DOI resolver #17

Closed katrinleinweber closed 5 years ago

katrinleinweber commented 5 years ago

Hello :-)

Are you certain that your entry data only contains the old DOI resolver URLs? If not, maybe this update helps catch all DOIs that pass through your system.

Cheers!

JPFrancoia commented 5 years ago

Hi @katrinleinweber ,

That's not how it works, because it's not my entry data. File hosts.py parses RSS feeds from the journals, and ACS entries have the urls of the articles stored like that:

'id': 'http://dx.doi.org/10.1021/acs.jpca.8b06197',

I don't decide how they store it, I just parse it.

katrinleinweber commented 5 years ago

Well, they might switch to the new recommendation at some point. Maybe a reg-ex that catches both variants might be useful to prepare, while keeping compatibility until then?

JPFrancoia commented 5 years ago

The tests will flag when this line doesn't work anymore