chembrows / ChemBrows

ChemBrows keeps you up-to-date with scientific literature
http://www.chembrows.com
GNU Lesser General Public License v3.0
5 stars 4 forks source link

Creation of topic "crystallography" #2

Closed nbehrnd closed 8 years ago

nbehrnd commented 8 years ago

Adding the journals of publication by the International Union of Crystallography

JPFrancoia commented 8 years ago

Hi !

@lovial forwarded me the email you sent us yesterday, we are preparing an answer (it will probably take time, your email contains a lot of good suggestions). In the future and if you are comfortable with github, you should open issues here (more people seeing them, more help, solved faster).

About this Pull Request (PR), it looks good for now, but there is little more work to do. Adding journals in config/fields adds a field entry in the tutorial, but to be able to use these journals, you also have to add them in the files located in the folder 'journals'.

In this folder, there is a .ini file for different publishers. wiley.ini for example contains Wiley's journals (not all of them, only the ones we selected). This configuration file follows a particular syntax:

Journal's title on the RSS page'SPACE':'SPACE'abbreviation of the journal'SPACE':'SPACE'url of the rss page'SPACE':'SPACE'optional boolean

So for example, if you want to add Acta Crystallographica Section A, you should add a new line in wiley.ini:

Acta Crystallographica Section A : Acta Cryst. A : http://onlinelibrary.wiley.com/rss/journal/10.1107/S20532733

You can see that adding a new journal is very easy.

However, you can't add a journal that doesn't belong to one of the publishers already in journals/. Sadly, it is the case for IUCrJ (but we can find a solution later).

Normally, it is the rule that the opener of a PR fixes it until it's merged, but if you want, I can fix it for you.

Thanks for your help !

nbehrnd commented 8 years ago

The acquaintance with ChemBrows, both via GUI as in terms of the inner mechanics, was just seeded. Even less with github -- yet later the day, the requested completing rectification will be added.