search

chemerisuk / better-dom

Live extension playground
http://chemerisuk.github.io/better-dom/
MIT License
545 stars 35 forks source link

"value.replace is not a function" in types$$DOM.emmet(), "[" case #22

Closed ikr closed 10 years ago

ikr commented 10 years ago

Happens here: https://github.com/chemerisuk/better-dom/blob/master/dist/better-dom.js#L244 -- because value is not a string, but a 1-element array, containing the string <aria-hidden=true class="better-dateinput-calendar-header"></aria-hidden=true>

The code triggering the error: http://ikr.su/h/react-period-of-stay-input/www/demo.html

chemerisuk commented 10 years ago

Yeah, it looks like a bug in version 2 emmet parser. For the date picker try to use 1.7.7 as it's more stable at present. And the plugin is not comparable with version 2 yet.

ikr commented 10 years ago

Oh, good to know, thanks!

chemerisuk commented 10 years ago

welcome. thanks for the report :)

chemerisuk commented 10 years ago

@ikr what tool did you use to include the polyfill on your page? Curious, because bower should not allow to use better-dom 2.

ikr commented 10 years ago

@chemerisuk Just a git clone -b in the build npm script https://gist.github.com/ikr/32463134480867867bb2

chemerisuk commented 10 years ago

got it. Plain git ignores bower.json of course :)