search

chemerisuk / cordova-plugin-app-review

Cordova plugin to review app
MIT License
40 stars 28 forks source link

Library update #13

Closed fredriksthlm closed 2 years ago

fredriksthlm commented 2 years ago

There is an update from Google that you now only need to include the review library, not the full Core library any longer!

Dependency: com.google.android.play:review:2.0.0 instead of com.google.android.play:core

Release notes: https://developer.android.com/reference/com/google/android/play/core/release-notes

There is an easy migration guide here: https://developer.android.com/guide/playcore#playcore-migration

chemerisuk commented 2 years ago

@fredriksthlm this is a good change indeed. Do you have time to submit PR with it? I’m very busy these days…

fredriksthlm commented 2 years ago

@fredriksthlm this is a good change indeed. Do you have time to submit PR with it? I’m very busy these days…

Look into this: https://github.com/chemerisuk/cordova-plugin-app-review/pull/14

fredriksthlm commented 2 years ago

@chemerisuk Will you update the npm as well? (I didnt update your description page regarding the method to set Core version. I guess you can just remove that part, since the core package should not be loaded)

mayainle commented 2 years ago

Hmm, for some reason I don't get the review dialog any longer. Even when I try with a completely new Google Play account. This was the latest change right? Did it work for you guys?

chemerisuk commented 2 years ago

@mayainle I apologise there was a bug in the latest update. It was fixed in 2.1.3, try to install it instead.

mayainle commented 2 years ago

@chemerisuk perfect thank you :)