fix freezed when resume

chemerisuk / cordova-plugin-app-review

Cordova plugin to review app

MIT License

40 stars 28 forks source link

fix freezed when resume #17

Closed uzosocom closed 2 years ago

uzosocom commented 2 years ago

It seems to be frozen by a programmatic resume.

https://user-images.githubusercontent.com/44468214/197250827-3e020be5-4c23-4de7-a109-b85fb6112fc1.mov

chemerisuk commented 2 years ago

@uzosocom you are right, I should not use await from the main thread. Another [simpler] fix will be to specify ExecutionThread.WORKER in @CordovaMethod. Do you mind to verify this option as well?

uzosocom commented 2 years ago

@chemerisuk Thanks.

https://user-images.githubusercontent.com/44468214/198289270-56afce7e-1447-4996-94df-083229947e4a.mov

chemerisuk commented 2 years ago

@uzosocom good work, merged!