search

chemerisuk / cordova-plugin-app-review

Cordova plugin to review app
MIT License
40 stars 28 forks source link

Android: fallback for requestReview() never triggering #3

Open EvelinJK opened 4 years ago

EvelinJK commented 4 years ago

The review dialogs themselves work fine for us on iOS and Android.

We're testing in development mode, which means the iOS rating dialog does always show since their limitations of 3/year don't apply here. But with Android, we can only show the dialog once in testing.

When requestReview() is called another time, the dialog is not shown again, but also the catch() does never trigger as described in the documentation. So we're unable to do anything as a fallback if the rating does not appear. There's no further logging or anything happening. Just any code we put in the catch() will never run.

Is there anything we have to take into account to get this working? Does this not work in development mode? And how to test the fallback then?

Thanks!

(P.S.: Otherwise the plugin works great, thanks for making it available 🤓 )

Tested with: Android 9.0 cordova: 10.0.0 cordova-android: 8.0.0 cordova-plugin-app-review: 2.0.1

BassamBasamad-Repo commented 4 years ago

Yes, the same happened with me,

chemerisuk commented 4 years ago

Read README carefully, there is a section with description of how to test the dialog for Android. When a test device registered within internal test group at Google Play, no limitation applied on calling inapp review dialog.

As for catch that is never called - expected behavior, this is how Google currently implemented their APIs. No way to determine if a user cancelled dialog or it failed to show.

BassamBasamad-Repo commented 4 years ago

I have read README, but still is not showing for the internal testing accounts.

Is there a way to register my device through play store console? how?

thanks,

sabedinia commented 4 years ago

I want to mention to check that the user has not already rated the app in production. Google doesn't let you query a user for this information to prevent abuse (because then people could start treating users who give the app 5 stars differently than to those who rated 1 star). Also make sure you are logged into Google Play store. IMO this feature is broken. It's a horrible API that needs to be reworked ...