search

chemerisuk / cordova-support-google-services

DEPRECATED. Cordova plugin to add google services support
MIT License
41 stars 107 forks source link

Revert and freeze gradle version to avoid 4.0.0 bug #27

Closed homer-jay closed 4 years ago

homer-jay commented 4 years ago

Released yesterday, the gradle 4.0.0 version causes this compilation error: ```Application build has failed with an error (Could not find org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.3.60-eap-25)````

Source: https://androidstudio.googleblog.com/2019/10/android-studio-40-canary-1-available.html

This pull request reverts the dependency to the last working version.

It is always a good practice to freeze dependencies to achieve reliable builds over time.

Phil15634280 commented 4 years ago

Many people are having this issue: https://stackoverflow.com/questions/58529904/error-could-not-find-org-jetbrains-kotlinkotlin-stdlib-jdk81-3-60-eap-25-in-i Would be great if this could be merged and released as soon as possible :)

Towerism commented 4 years ago

Another pull request aims to solve this problem: #26. Although this is probably a better way to fix it.

Towerism commented 4 years ago

Which ever one gets merged, please do it ASAP.

galfert commented 4 years ago

I think this is a better approach than #26.

👍

lucbors commented 4 years ago

Change is good. Uses the latest stable version of gradle before 4.0.0. Please merge. Thanks

rodrigograca31 commented 4 years ago

For the record: I've sent an email to the plugin owner asking to merge this PR.

rodrigograca31 commented 4 years ago

@jimbergman You can only review? Can't you merge?

jimbergman commented 4 years ago

I am not able to merge this. Anybody can review a pull request, but the maintainer has to do the merge. It looks like @chemerisuk hasn't made any commits to GitHub since June. ☹️

chemerisuk commented 4 years ago

Hi guys, I think better to set com.android.tools.build:gradle:3.+ because plugin used in different versions of cordova-android. Version com.android.tools.build:gradle:3.5.1 requires gradle 5.1.1+.

chemerisuk commented 4 years ago

Duplicates https://github.com/chemerisuk/cordova-support-google-services/pull/26

rodrigograca31 commented 4 years ago

@chemerisuk thanks for your work :muscle:

Would it be possible to add someone else as a colaborator to this repo to assure the maintenance of this code? I ask this because according to your github profile it almost seems like you died in June... :cry: so I was afraid we would loose the ability to update this package... (Settings --> collaborators)

Thanks.