search

chemicstry / recksplorer

Lightning Network Explorer
179 stars 72 forks source link

Display total capacity with thousands separators #6

Closed uyhcire closed 6 years ago

uyhcire commented 6 years ago

Display 397,642,447 sat ($39,439.73 USD) instead of 397642447 sat (39439.73 USD)

tgburgin commented 6 years ago

Think this needs to be a toggle at best, not just blanket change. User locale specific maybe?

chemicstry commented 6 years ago

Firefox docs state that setting locale to undefined should chose the one that is preferred by OS.

See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString

If someone can confirm that this works on most browsers and change the PR accordingly, I will merge it.