search

cheminfo-js / nmr-predictor

NMR chemical shift predictor
MIT License
0 stars 2 forks source link

Should we keep this as a separate project ? #2

Closed lpatiny closed 7 years ago

lpatiny commented 7 years ago

nmr-predictor is included in spectra-data but both depends of openchemlib-extended.

Does this mean we will load twice openchemlib-extended (1Mb) ? I think case I think it would be better to remove this project and put in in spectra-data.

Any comment @stropitek

targos commented 7 years ago

Does this mean we will load twice openchemlib-extended (1Mb) ?

Only if they depend on a different version

I think it would be better to remove this project and put in in spectra-data.

I don't think so. It's not directly related

stropitek commented 7 years ago

I agree with @targos. We should keep nmr-predictor a separate library

lpatiny commented 7 years ago

Ok good.