search

cheminfo-js / spectra-data

Library to deal with spectra (IR, UV, ...), 1D NMR as well as 2D NMR
https://cheminfo-js.github.io/spectra-data
MIT License
4 stars 0 forks source link

super() is implicit in constructor #42

Closed lpatiny closed 7 years ago

lpatiny commented 7 years ago

This code is useless

https://github.com/cheminfo-js/spectra-data/blob/master/src/NMR.js#L18

andcastillo commented 7 years ago

It seems that super() is not implicit. Webstorm complains if if I have a empty constructor. On the other hand I don't want to overload the constructor, so I don't need to define it. It will inherit from the super.

lpatiny commented 7 years ago

@targos Any comments on this ?

targos commented 7 years ago

The constructor itself is implicit (with call to super) as @andcastillo pointed out.