codecov[bot]
commented
2 years ago Codecov Report
Base: 91.60% // Head: 94.86% // Increases project coverage by +3.26% :tada:
Coverage data is based on head (
0f2a13e) compared to base (141d9ee). Patch coverage: 86.51% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #13 +/- ## ========================================== + Coverage 91.60% 94.86% +3.26% ========================================== Files 24 25 +1 Lines 524 526 +2 Branches 154 149 -5 ========================================== + Hits 480 499 +19 + Misses 43 26 -17 Partials 1 1 ``` | [Impacted Files](https://codecov.io/gh/cheminfo/biologic-converter/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo) | Coverage Δ | | |---|---|---| | [src/mps/utility/addKeyValueToResult.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL21wcy91dGlsaXR5L2FkZEtleVZhbHVlVG9SZXN1bHQudHM=) | `100.00% <ø> (ø)` | | | [src/mpt/parseData.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL21wdC9wYXJzZURhdGEudHM=) | `85.00% <75.00%> (-15.00%)` | :arrow_down: | | [src/mpr/modules/utility/mapIRangeToMPT.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL21wci9tb2R1bGVzL3V0aWxpdHkvbWFwSVJhbmdlVG9NUFQudHM=) | `83.63% <83.63%> (ø)` | | | [src/mpr/modules/parseData.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL21wci9tb2R1bGVzL3BhcnNlRGF0YS50cw==) | `100.00% <100.00%> (ø)` | | | [src/mpr/modules/utility/addData.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL21wci9tb2R1bGVzL3V0aWxpdHkvYWRkRGF0YS50cw==) | `71.42% <100.00%> (-28.58%)` | :arrow_down: | | [src/mpr/modules/utility/getParameters.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL21wci9tb2R1bGVzL3V0aWxpdHkvZ2V0UGFyYW1ldGVycy50cw==) | `95.00% <100.00%> (ø)` | | | [src/mps/parseMPS.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL21wcy9wYXJzZU1QUy50cw==) | `90.47% <100.00%> (ø)` | | | [src/mpt/parseMPT.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL21wdC9wYXJzZU1QVC50cw==) | `100.00% <100.00%> (ø)` | | | [src/utility/ids.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL3V0aWxpdHkvaWRzLnRz) | `100.00% <100.00%> (ø)` | | | [src/utility/techniqueFromLongName.ts](https://codecov.io/gh/cheminfo/biologic-converter/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-c3JjL3V0aWxpdHkvdGVjaG5pcXVlRnJvbUxvbmdOYW1lLnRz) | `100.00% <100.00%> (ø)` | | | ... and [1 more](https://codecov.io/gh/cheminfo/biologic-converter/pull/13/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Now the data returned from both parsers is
Record<string, MeasurementVariable>.Currently, the outputs for MPT, MPR are similar, with a few differences (for the data keys.):
Still what is right now should be good to start plotting some stuff (we will see.).
I have been fixing both parsers but wrote only one from scratch (MPT), so sometimes it takes time.
@lpatiny