cheminfo / biologic-converter

MIT License
1 stars 1 forks source link

Unimplemented names #36

Open targos opened 1 year ago

targos commented 1 year ago
targos commented 1 year ago

/cc @santimirandarp

ghost commented 1 year ago

Yes, I am aware, it is just that it gets more complicated for some of those. I will take a look so that if I can't do it at least I can write a brief for the next person trying. Apart from that, I am weary about writing code too inspired in code written by others (in this particular case.)

targos commented 1 year ago

I am weary about writing code too inspired in code written by others (in this particular case.)

I don't know what you have in mind, but unless the "code written by others" you are talking about is secret and you are not supposed to have access to it, this shouldn't be a problem. If I understand correctly, you read the code to get information about the file format, not to copy an algorithm.

ghost commented 1 year ago

Interesting. Yes I guess I am just a bit scared and lack experience, I have been explained this already.

ghost commented 1 year ago

Basic GEIS and PEIS is being added in the PR referenced above @targos. Still needs a bit of work. The parameter names are now as they appear in the text file for convenience.