feat: add types for ConsoleLogger

cheminfo / cheminfo-types

https://cheminfo.github.io/cheminfo-types/

MIT License

2 stars 3 forks source link

feat: add types for ConsoleLogger #101

Closed lpatiny closed 3 months ago

lpatiny commented 3 months ago

@targos What do you think about this type ? I would like that some libraries like openchemlib-utils are able to send 'warn' but if a logger is not specified it simply uses console.warn.

Is this something acceptable to you ?

targos commented 3 months ago

This doesn't seem correct. Please show an example of use in real code.

lpatiny commented 3 months ago

https://github.com/cheminfo/openchemlib-utils/blob/a9ad35d649b278cebc9c878fb06ce6a67b01b4bb/src/topic/TopicMolecule.ts#L294-L297